Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handle_cast fake return value #296

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix handle_cast fake return value #296

merged 1 commit into from
Jul 2, 2018

Conversation

joshuawscott
Copy link
Member

Make dialyzer happy

Fixes #295

Substantive change:
https://github.com/kafkaex/kafka_ex/compare/fix_dialyzer?expand=1#diff-ea0f264471158a5b4d2686ee693cc8ffR320

The rest is formatting the using function with mix format

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 105 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/kafkaex/kafka_ex/pulls/296.

dantswain
dantswain approved these changes Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@dantswain dantswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks!

@joshuawscott joshuawscott merged commit 236629e into master Jul 2, 2018
@joshuawscott joshuawscott deleted the fix_dialyzer branch July 2, 2018 17:48
@joshuawscott joshuawscott mentioned this pull request Jul 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantswain dantswain dantswain approved these changes

@bjhaid bjhaid bjhaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialyzer error on GenConsumer
3 participants
@joshuawscott @dantswain @bjhaid